feat(pack): add support for scaffolding new extensions

[sarthaksarthak9]

add support for scaffolding new extensions

Summary

add support for scaffolding new extensions

Output

Before

After

Documentation

• Should this change be documented?
  • Yes, see #___
  • No

Related

Resolves #1636

[sarthaksarthak9]

@natalieparellano could you plz review the pr ?

[sarthaksarthak9]

@natalieparellano I'm working on test for newExtension. Do we have anything similar to newBuildpack() method https://pkg.go.dev/github.com/buildpacks/pack/internal/commands/testmocks#MockPackClientMockRecorder.NewBuildpack for extension ?

[sarthaksarthak9]

I run make build, make format, make tidy and make verify they are running good at my end !! I don't know y these tests are failing !!

[jjbustamante]

I run make build make format make tidy and make verify they are running good at my end !! I don't know y these tests are failing !!

Hi @sarthaksarthak9

For what I can see, it looks like your mock setup is missing some information

 Got: {0.8 /tmp/build-test1320509439/targets example/targets 1.0.0 [] [{linux arm v6 [{ubuntu [14.04 16.04]}]}]} (client.NewBuildpackOptions)

  Want: is equal to {0.8 /tmp/build-test1320509439/targets example/targets 1.0.0} (client.NewExtensionOptions)

Your expected object is missing [] [{linux arm v6 [{ubuntu [14.04 16.04]}]}] these attributes.

Maybe here:

mockClient.EXPECT().NewBuildpack(gomock.Any(), client.NewExtensionOptions{
					API:     "0.8",
					ID:      "example/targets",
					Path:    filepath.Join(tmpDir, "targets"),
					Version: "1.0.0",
				}).Return(nil).MaxTimes(1)

You need to add more details on the targets options

[sarthaksarthak9]

@jjbustamante targets are not present in ExtensionDescriptor struct and ExtensionNewFlags, do I have to add it ? https://github.com/buildpacks/pack/blob/main/pkg/dist/extension_descriptor.go

[sarthaksarthak9]

@natalieparellano @jjbustamante I think we have testDeepContains as last unit test, still Make file throwing an error!! Could you pls check this out!!

[jjbustamante]

Hi @sarthaksarthak9

I think the problem is that your tests are still not passing. I cloned your branch and try to fix them. This is what I changed:

I think you copied and pasted some tests from a previous command, which is ok, but you didn't changed the actual method you wanna mock NewExtension. The other error seems to be with the API version.

I did those changes and the tests started passing locally

[sarthaksarthak9]

Hi @sarthaksarthak9

I think the problem is that your tests are still not passing. I cloned your branch and try to fix them. This is what I changed:

I think you copied and pasted some tests from a previous command, which is ok, but you didn't changed the actual method you wanna mock NewExtension. The other error seems to be with the API version.

I did those changes and the tests started passing locally

This is extremely helpful. I completely missed that it needed updating. Thank you for catching that!

[codecov]

Codecov Report

Attention: Patch coverage is 29.16667% with 102 lines in your changes missing coverage. Please review.

Project coverage is 78.42%. Comparing base (e3f8bc2) to head (63de73b).
Report is 209 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2026      +/-   ##
==========================================
- Coverage   79.63%   78.42%   -1.21%     
==========================================
  Files         176      177       +1     
  Lines       13214    13352     +138     
==========================================
- Hits        10522    10470      -52     
- Misses       2022     2213     +191     
+ Partials      670      669       -1     

Flag	Coverage Δ
os_linux	78.04% <29.17%> (-0.51%)	⬇️
os_macos	75.90% <29.17%> (-0.49%)	⬇️
os_windows	77.77% <29.17%> (-1.25%)	⬇️
unit	78.42% <29.17%> (-1.21%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

[sarthaksarthak9]

I commits the changes with wrong author, due to which DCO is not passing because of this I am closing this pull request and opening a new