Initialize default LayerMetadataRestorer and SBOMRestorer if none provided
#1333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pbusko
force-pushed
the
default-layer-restorer
branch
from
9d0e1e0
to
2195c35
Compare
There was a problem hiding this comment.
I would love to see us move the logic for constructing a new restorer into a "factory" method similar to ConnectedFactory.NewAnalyzer, as part of our ongoing quest to move stuff out of the main package. But, that doesn't need to block improving this code now.
|
Rebasing against |
…vided Co-authored-by: Ralf Pannemans <[email protected]> Signed-off-by: Pavel Busko <[email protected]>
pbusko
force-pushed
the
default-layer-restorer
branch
from
2195c35
to
2d8ff24
Compare
natalieparellano
approved these changes
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Initialize default
layer.LayerMetadataRestorerandlayer.SBOMRestorerstructs if none provided.Release notes
Related
Resolves #___
Context
At the moment, it is impossible to reuse
phase.Restorerstructure due to the usage of two internal structs:layer.LayerMetadataRestorerandlayer.SBOMRestorer. Defaulting them with the default constructors would allow re-use of thephase.Restorerwithout opening up the internal package.This change would greatly improve future work on cloudfoundry/community#796