Adds -run as an input to the analyzer #1005
Conversation
natalieparellano
force-pushed
the
runext/analyze-995
branch
from
ed81ef4
to
f04ce7f
Compare
|
@joe-kimmel-vmw this might intersect a bit with the changes in #994, but I'll hold off on trying to merge this one until that one is through |
|
This also needs to include |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1005 +/- ##
==========================================
+ Coverage 64.74% 64.76% +0.02%
==========================================
Files 86 86
Lines 6179 6219 +40
==========================================
+ Hits 4000 4027 +27
- Misses 1799 1808 +9
- Partials 380 384 +4
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
natalieparellano
force-pushed
the
runext/analyze-995
branch
from
f5dbf38
to
a9d828c
Compare
- Also adds unit tests for create inputs Signed-off-by: Natalie Arellano <[email protected]>
natalieparellano
force-pushed
the
runext/analyze-995
branch
from
a9d828c
to
aa1765c
Compare
|
|
||
| when("layers directory is provided", func() { | ||
| it("writes analyzed.toml at the layers directory", func() { | ||
| inputs.LayersDir = "some-layers-dir" | ||
| err := platform.ResolveInputs(platform.Analyze, &inputs, logger) | ||
| h.AssertNil(t, err) | ||
| h.AssertEq(t, inputs.AnalyzedPath, filepath.Join("some-layers-dir", "analyzed.toml")) | ||
| }) | ||
| }) |
There was a problem hiding this comment.
This test was repeated in this file
|
@joe-kimmel-vmw I checked the merge conflict - and thankfully it's not as bad as I thought, just some log messages that were updated in analyzer.go. I'll go ahead and merge this one so that I can pick up other issues in the "extensions" track |
Fixes #995