First pass at Pact consumer tests #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nprizal
reviewed
Jun 13, 2024
| @@ -1 +1 @@ | |||
| FROM public.ecr.aws/docker/library/golang:1.22.3@sha256:f43c6f049f04cbbaeb28f0aad3eea15274a7d0a7899a617d0037aec48d7ab010 | |||
| FROM public.ecr.aws/docker/library/golang:1.21.11 | |||
There was a problem hiding this comment.
pact-go doesn't work with go 1.22.x at the moment.
pact-foundation/pact-go#402
Linux x86_64 users
Using GoLang 1.22.x ?
Resolution: disable -race
Need to use -race?
Resolution: downgrade to 1.21.x
nprizal
force-pushed
the
tat-184-add-pact-for-integration-testing
branch
3 times, most recently
from
909977b to
f0371b5
Compare
wooly
force-pushed
the
tat-184-add-pact-for-integration-testing
branch
from
a6b32fe to
1dd8ff8
Compare
nprizal
approved these changes
Jun 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
To prevents the test splitter API from breaking its promise with the client, we are adding a contract testing using Pact.io. This PR replaces the server mocking in
apipackage tests with Pact mock provider using pre-defined contract. This contract comes in the form of interactions containing information such as the expected request, the expected response, and a 'state' that the provider needs to be in to honour the interaction. These interactions can be generated asJSONfile that can be used by test splitter API to verify that its behaviour doesn't break the contracts.