Check that a pipeline upload error actually comes from the JSON marshaller and exit early #1963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…aller and exit early While this may be more than just recursive pipeline, in all cases where the pipeline cannot be marshaled to JSON, there is no point to retry the upload.
triarius
commented
Feb 21, 2023
|
|
||
| return jsonerr | ||
| } | ||
|
|
||
| // 422 responses will always fail no need to retry | ||
| if apierr, ok := err.(*api.ErrorResponse); ok && apierr.Response.StatusCode == 422 { |
There was a problem hiding this comment.
While this part should also use the errors.As pattern as above, there is another PR out there where I have made this change: #1927
When this is merged, that should have merge conflicts. But I will take care of it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In all cases where the pipeline cannot be marshaled to JSON, there is no point to retry the upload.
Retries will keep the agent busy for about 5 min, which is a waste of customers' compute time.