fix(security): harden env ignore, host allowlist, and logout cookies - #925
Open
dakota2499 wants to merge 1 commit into
Open
fix(security): harden env ignore, host allowlist, and logout cookies#925dakota2499 wants to merge 1 commit into
dakota2499 wants to merge 1 commit into
Conversation
Prevent accidental .env.bak credential commits, fail-closed production host filtering when MC_ALLOWED_HOSTS is empty, and clear both secure and legacy session cookies on logout. Adds regression tests from Codex audit triage (Hermes agreed).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.env*variants by default (including.env.bak*) so backup env files with secrets cannot be accidentally committed; keep.env.exampleand.env.testtrackable.MC_ALLOWED_HOSTSis empty (only implicit local hosts), unlessMC_ALLOW_ANY_HOST=1is set.__Host-mc-sessionand legacymc-sessioncookies so HTTP→HTTPS transitions cannot leave a valid session behind.Context
These changes came from a local security audit of Mission Control. They are small, high-value hardening fixes with unit test coverage.
Test plan
vitest run src/proxy.test.ts(includes emptyMC_ALLOWED_HOSTSfail-closed case)vitest run src/lib/__tests__/session-cookie.test.ts