api/GetAction: add handling for failed build action #8451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When an invocation failed because of a non-test(aka build) action, the TargetCompleted event will not contains the relevant output files. Relevant stderr/stdout of the failed action can be found in the ActionCompleted event instead. Enhance the GetAction rpc logic by only handling successful TargetCompleted events. For the failed cases, add additional logic to create Action entries from ActionCompleted events. Refactor FillActionFromBuildEvent to switch on event id instead of event payload.
sluongng
force-pushed
the
sluongng/improve-get-action
branch
from
32060a6 to
5659e62
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an invocation failed because of a non-test(aka build) action, the
TargetCompleted event will not contains the relevant output files.
Relevant stderr/stdout of the failed action can be found in the
ActionCompleted event instead.
Enhance the GetAction rpc logic by only handling successful
TargetCompleted events. For the failed cases, add additional logic to
create Action entries from ActionCompleted events.
Refactor FillActionFromBuildEvent to switch on event id instead of event
payload.