Add remote-download command to CLI #8375
Open
+159
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bduffany
force-pushed
the
cli-remote-download
branch
2 times, most recently
from
2c38898 to
008c443
Compare
fmeum
approved these changes
Feb 11, 2025
bduffany
force-pushed
the
cli-remote-download
branch
2 times, most recently
from
4253242 to
65ce425
Compare
bduffany
force-pushed
the
cli-remote-download
branch
from
65ce425 to
72e6882
Compare
sluongng
reviewed
Feb 14, 2025
sluongng
reviewed
Feb 14, 2025
| var ( | ||
| flags = flag.NewFlagSet("remote-download", flag.ContinueOnError) | ||
|
|
||
| target = flags.String("target", login.DefaultApiTarget, "Remote gRPC target. Must support bytestream and remote asset APIs.") |
There was a problem hiding this comment.
I would appreciate getting an API key flag here to target specific tenants.
Or if we can get the existing API key from .git/config by default, that would be nice as well.
Co-authored-by: Son Luong Ngoc <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Useful for ad-hoc testing of the Fetch API (
--experimental_remote_downloaderin bazel).