Make firecracker CoW tests run on CI #7429
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bduffany
changed the title
bduffany
force-pushed
the
cow-test-ci
branch
4 times, most recently
from
dcd4377
to
33ad403
Compare
bduffany
commented
Sep 11, 2024
| workDirForkOriginalSnapshot := testfs.MakeDirAll(t, rootDir, "work-fork-og-snapshot") | ||
| originalSnapshotKey := baseVM.SnapshotKeySet().GetBranchKey() | ||
| originalSnapshotKey.SnapshotId = baseSnapshotId | ||
| originalSnapshotKey := &fcpb.SnapshotKey{ |
There was a problem hiding this comment.
There were 2 issues here:
- We weren't doing anything with
originalSnapshotKey- from the comment I think the intent was to set it on ContainerOpts so that we resume from this specific snapshot - I forgot to update this logic here when we simplified snapshot-specific keys so that they only include the instance_name + snapshot_id.
|
yikes, the tests are running extremely slowly. going to start on a separate PR to do the file-locking thing with the IP addresses, so that we can shard this test. |
maggie-lou
approved these changes
Sep 12, 2024
bduffany
added a commit
that referenced
this pull request
Sep 23, 2024
…e machine (#7439) Follow-up from #7429 * Add optional `flock`-based IP range locking to prevent concurrent test shards from trying to use the same IP range concurrently. * This is useful for firecracker tests, as well as running multiple firecracker executors locally. * Don't try to clean up network namespaces in tests, because they might be in use. * I don't expect that too many of these will accumulate, but if it does happen, we can find a way to clean up "orphaned" namespaces, maybe by associating them with lockfiles. * Don't try to clean up the shared executor root directory in tests either, to prevent converted ext4 image files from disappearing mid-test. * Added a TODO to provision these images as data deps of the test instead of converting during the test. * Set `shard_count` on `firecracker_test`. (This won't actually buy us a ton of concurrency until we disable exclusive task scheduling on the bare pool.) **Related issues**: buildbuddy-io/buildbuddy-internal#3758
bduffany
force-pushed
the
cow-test-ci
branch
from
33ad403
to
6723469
Compare
bduffany
force-pushed
the
cow-test-ci
branch
from
6723469
to
3d40b1e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issues: N/A