Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Buildbarn logo svg #178

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add Buildbarn logo svg #178

wants to merge 2 commits into from

Conversation

moroten
Copy link
Contributor

@moroten moroten commented Sep 13, 2023

Supplying two logos, one with rounded ends on the lines but then also, unfortunately, manually edited after Drawio export.

I like the one with rounded line caps best but feel free to choose the one you prefer. Where shall it be integrated into the docs? Should there be a bb-docs for GitHub pages or should it be put in bb-deployments?

@moroten moroten marked this pull request as ready for review September 13, 2023 06:43
@moroten moroten marked this pull request as draft September 13, 2023 06:44
@moroten moroten marked this pull request as ready for review September 14, 2023 15:42
@EdSchouten
Copy link
Member

Hey! That's awesome. I think I like the rounded one most as well.

I think that having a bb-docs repo only makes sense if we also commit to writing actual documentation. If this is not going to happen in the nearby future, maybe best to just keep it here?

@moroten
Copy link
Contributor Author

moroten commented Sep 16, 2023

I just realised that the bb-browser favicon is also a good alternative, maybe even better.

@moroten
Copy link
Contributor Author

moroten commented Oct 20, 2023

I'm happy with this update now. Will be integrated in buildbarn/bb-browser#46.

@EdSchouten
Copy link
Member

Considering that we likely want to use this all over the place (pkg/otel, bb-scheduler, bb-browser, ...), what are your thoughts on just having a pkg/logo in this repo that uses //go:embed to pull it in? That way we can easily reference it from within Go code without further trickery.

@moroten
Copy link
Contributor Author

moroten commented Oct 20, 2023

Nice idea, Ed! Updated the commit accordingly.

var faviconSvg []byte

// FaviconSvg holds the Buildbarn logo and can be used as favicon in web browsers.
var FaviconSvg = faviconSvg
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out of curiosity, why the indirection? We can't make the go:embed variable public? I think we should also call this FaviconSVG, as in Go they tend to write abbreviations like HTTP, XML, etc. in all caps.

Copy link
Member

@EdSchouten EdSchouten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can I persuade you to patch up pkg/otel/active_spans.html to make use of this?

@moroten
Copy link
Contributor Author

moroten commented Nov 9, 2023

Can I persuade you to patch up pkg/otel/active_spans.html to make use of this?

I tried but failed to encode the favicon in the otel test. What's the best way forward?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants