Feature/upgrade go dependencies 2023-12-18 #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
What's really annoying about the latest version of OpenTelemetry is that they've redefined the Span, Tracer and TracerProvider interfaces to contain private methods, so that you no longer have the ability to fully implement them yourself. This is done to provide gradual forward compatibility, but I don't buy it. In my case I want to get explicit build failures, so that I know I need to extend my implementations. Solve this by explicitly embedding embedded.* into our types. For gomock we now need to declare our very own wrappers. Very annoying.
stagnation
force-pushed
the
feature/upgrade-go-dependencies-2023-12-18
branch
from
2a5244d to
9f9ef21
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's really annoying about the latest version of OpenTelemetry is that they've redefined the Span, Tracer and TracerProvider interfaces to contain private methods, so that you no longer have the ability to fully implement them yourself. This is done to provide gradual forward compatibility, but I don't buy it. In my case I want to get explicit build failures, so that I know I need to extend my implementations.
Solve this by explicitly embedding embedded.* into our types. For gomock we now need to declare our very own wrappers. Very annoying.