Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add validity check to isReference and String #9

Closed
wants to merge 1 commit into from
Closed

feat: add validity check to isReference and String #9

wants to merge 1 commit into from

Conversation

strollinghome
Copy link

#2

@strollinghome strollinghome changed the title feat: adds validity check to isReference and String feat: add validity check to isReference and String Apr 9, 2019
@strollinghome
Copy link
Author

@mrinalwadhwa not sure if splitting the function is the best way to get around the cyclomatic complexity linter error. I saw you added // nolint: gocyclo to the parsePath() function but I'm not sure if we'd want to do that here. Lmk what you think.

@mrinalwadhwa
Copy link
Member

superseded by did 1.0 #8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@strollinghome @mrinalwadhwa