Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Params Break Syntax #15

Open
pascaldekloe opened this issue Jan 2, 2023 · 3 comments
Open

Params Break Syntax #15

pascaldekloe opened this issue Jan 2, 2023 · 3 comments

Comments

@pascaldekloe
Copy link

Test case did:example:123;service=agent is not a valid DID. The method-specific identifier does not permit any semicolon (';') characters, and paths should start with a slash ('/').
@mrinalwadhwa
Copy link
Member

@pascaldekloe thank you for pointing that out. The DID spec was a draft when I wrote the library and had examples like that back then. We'd happily accept PRs if you would like to work on a fix.

@pascaldekloe
Copy link
Author

A fix as in removal of the parameters then, I presume?

pascaldekloe added a commit to pascaldekloe/did-ockam that referenced this issue Jan 3, 2023
@pascaldekloe
chore: new standard compliance with 3rd party library, fixes issue bu…
0e6bc76 
…ild-trust#15
pascaldekloe added a commit to pascaldekloe/did-ockam that referenced this issue Jan 3, 2023
@pascaldekloe
chore: new standard compliance with 3rd party library, fixes issue bu…
74d27b1 
…ild-trust#15
@pascaldekloe
Copy link
Author

Picked up in pull request #16.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mrinalwadhwa @pascaldekloe