Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fonts not found #158

Closed
shinebayar-g opened this issue Jan 15, 2019 · 14 comments
Closed

Fonts not found #158

shinebayar-g opened this issue Jan 15, 2019 · 14 comments

Comments

@shinebayar-g
Copy link
Collaborator

I've setup nginx reverse proxy in front of script server as described here. (with basic auth)
However when I browse my script-server address, some fonts are not loading. It's because they're looking at wrong path. I think correct path should be:

https://mydomain.com/script-server/fonts/roboto-latin-300.woff2

etc currently it's looking at

https://mydomain.com/fonts/roboto-latin-300.woff2

which is incorrect IMO. I think It didn't happen on 1.12.0 release. (I'm running on dev release)

image

@bugy
Copy link
Owner

bugy commented Jan 15, 2019

Thanks! Most probably it comes after my large web-side refactoring on dev. I'll have a look.

@bugy bugy added the bug label Jan 15, 2019
@shinebayar-g
Copy link
Collaborator Author

Just tried to reproduce this errors on 1.12.0 release. Looks like these are new additions since last release.
1.12.0 release uses these:

https://mydomain.com/script-server/css/fonts/roboto/Roboto-Regular.woff2
https://mydomain.com/script-server/css/fonts/roboto/Roboto-Light.woff2

@shinebayar-g
Copy link
Collaborator Author

Also, consider what if user want to put script-server on different path like mydomain.com/not-script-server etc, in such case it still should be working. I mean it should be flexible.

@bugy
Copy link
Owner

bugy commented Jan 15, 2019

In the code I don't have anything related to script-server path, so it should be ok.

@shinebayar-g
Copy link
Collaborator Author

That's great.

bugy added a commit that referenced this issue Jan 15, 2019
@bugy bugy added the resolved label Jan 15, 2019
@bugy
Copy link
Owner

bugy commented Jan 15, 2019

Should be ok now on the latest dev

@shinebayar-g
Copy link
Collaborator Author

shinebayar-g commented Jan 16, 2019

Confirm fixed. Little bit confused when see this:

image

@shinebayar-g
Copy link
Collaborator Author

Issue still appears in admin.html
image

@shinebayar-g shinebayar-g reopened this Jan 16, 2019
@bugy
Copy link
Owner

bugy commented Jan 16, 2019

thanks for sharing! True, admin page has different paths :(

And thanks for telling about dev release date. I started such releases only recently (actually 20 days ago), and don't know all the details about it. Hopefully it could be fixed somehow via travis

@bugy bugy removed the resolved label Jan 16, 2019
@bugy
Copy link
Owner

bugy commented Jan 17, 2019

After couple of hours of fighting with webpack and ccs/file loader plugins, I still couldn't find a way to solve it...
So it will take some time

@shinebayar-g
Copy link
Collaborator Author

Ugh, i see. Also could you please add go back to homepage button somewhere? Once you go to admin page, there is no navigation back.

@bugy
Copy link
Owner

bugy commented Jan 17, 2019

Created a ticket for it: #166

@bugy
Copy link
Owner

bugy commented Jan 17, 2019

Fonts should be fixed on admin page as well now.

Please be careful, in a recent commit for #137 I changed server API urls. So if the JS code is cached in browser, while server side is updated, it will cause issues. Apart from caches it shouldn't cause any other problems

@bugy bugy added the resolved label Jan 17, 2019
@shinebayar-g
Copy link
Collaborator Author

Confirmed fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants