Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Google Oauth: show progress bar during authentication process #157

Closed
bugy opened this issue Jan 8, 2019 · 1 comment
Closed

Google Oauth: show progress bar during authentication process #157

bugy opened this issue Jan 8, 2019 · 1 comment
Labels
feature resolved

Comments

@bugy
Copy link
Owner

bugy commented Jan 8, 2019

After authenticating with Google OAuth, "Sign in with Google" button stays there for 10-20 seconds without any visible progress indicator. And after that time the page is redirected to index page.

So to avoid confusion it, there should be some indicator and the button should be disabled, probably.
@bugy bugy added the feature label Jan 8, 2019
bugy added a commit that referenced this issue Jan 26, 2019
@bugy
#157 added indication while performing authentication + improved goog…
c3ecae5 
…le oauth button styling
@bugy bugy added the resolved label Jan 26, 2019
@bugy
Copy link
Owner Author

bugy commented Jan 26, 2019

Added a label during authentication process (both for Ldap and Google OAuth)
Also improved google button styling (to better reflect guidelines)

@bugy bugy closed this as completed Jan 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature resolved
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bugy