Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow reconnection to running script #100

Closed
bugy opened this issue Feb 26, 2018 · 3 comments
Closed

Allow reconnection to running script #100

bugy opened this issue Feb 26, 2018 · 3 comments

Comments

@bugy
Copy link
Owner

bugy commented Feb 26, 2018

If user reloaded (or opened and then closed) a page, he should still see and control currently executing script.
At the moment this is possible only within opened page.
Also, #94 config should be removed - all the scripts should have a possibility to run in disconnected mode

@bugy
Copy link
Owner Author

bugy commented Jun 1, 2018

Done.
The setting "kill_on_disconnect" was removed. Now it's always true (i.e. closing a web page won't affect execution).
While script is running, it's always possible to connect to it, even from multiple windows/tabs. In this case all of them should recieve identical information regarding output and downloadable files.
If no user session is active and execution finishes, then opening the web page should show script results. However in this case, the results will be shown only on the first page open.

@bugy bugy added the resolved label Jun 1, 2018
@bugy
Copy link
Owner Author

bugy commented Jun 4, 2018

This issue has a large leak with running behind a proxy without authentication. In this case all user IPs are replaced with the IP of the proxy and script-server thinks, that it's the same user all the time.
We can get real user IP via X-forwarded-for header, but it's vulnerable to attacks, so this improvement should be done in a smarter way.

@bugy
Copy link
Owner Author

bugy commented Jun 4, 2018

Moved proxy IP issue to a separate task, since it's related not only to active executions: #114

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant