Transparently handle EINTR during Read #69
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This has been observed in particular on MacOS, in this case just retry the call without throwing the error back to the user. Related to: arduino/arduino-cli#504 arduino/arduino-pro-ide#157
cmaglie
added a commit
to cmaglie/arduino-cli
that referenced
this pull request
Dec 3, 2019
Includes a fix to serial.Read method. Should fix: arduino#504 Actual patch: bugst/go-serial#69
cmaglie
added a commit
to arduino/arduino-cli
that referenced
this pull request
Dec 6, 2019
… port open (#507) * Update go-serial library to latest version Includes a fix to serial.Read method. Should fix: #504 Actual patch: bugst/go-serial#69 * Using versioned release of go.bug.st/serial
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has been observed in particular on MacOS, in this case just retry the call without throwing the error back to the user.
Related to:
arduino/arduino-cli#504
arduino/arduino-pro-ide#157
@kittaakos