This repository has been archived by the owner on Jan 12, 2021. It is now read-only.
use the temporary directory specified by the OS for temporary files #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bengourley
approved these changes
Jul 23, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
fs.mkdtemponly returns the name of the temporary folder, which means that it gets created in the current working directory. this change adds the path to the OS's temporary folder where everyone can (usually) write to.why
in our build process we don't have permission to write to the folder where the build is run, so using this library fails. also in theory it feels a bit better to write temporary files to an actual temporary folder.