This repository has been archived by the owner on Jan 12, 2021. It is now read-only.

Sourcemaps overwritten #23

Closed

chrisnovak opened this issue Jul 31, 2018 · 3 comments

chrisnovak commented Jul 31, 2018 •

edited

Loading

Expected behavior

Sourcemaps are not overwritten by default.

Observed behavior

Sourcemaps are overwritten when using the CLI—regardless of whether --overwrite false is included or not.

Steps to reproduce

bugsnag-sourcemaps --api-key XXXXX --app-version 173 --source-map bundle/android-release.bundle.map --minified-file bundle/android-release.bundle --minified-url index.android.bundle --upload-sources --overwrite false

or

bugsnag-sourcemaps --api-key XXXXX --app-version 173 --source-map bundle/android-release.bundle.map --minified-file bundle/android-release.bundle --minified-url index.android.bundle --upload-sources

Version

1.0.3

Additional Info

We've also confirmed that the sourcemaps are being overwritten in the Bugsnag UI.

The text was updated successfully, but these errors were encountered:

bengourley added a commit that referenced this issue


          fix: Remove overwrite from payload when false

8dedca1

Fixes #23

bengourley mentioned this issue

Better handling of boolean arguments #24

Merged

bengourley added a commit that referenced this issue


          fix: Remove overwrite from payload when false

88a2c65

Fixes #23

Contributor

bengourley commented Aug 1, 2018

Hi @chrisnovak, thanks for filing this issue. We managed to reproduce the issue, and I'm working on a fix over in #24. I'll keep you updated.

bengourley closed this as completed in

4d11f1a

Author

chrisnovak commented Aug 1, 2018

Thank you for fixing this quickly! Confirmed working on 04e2846.

Contributor

bengourley commented Aug 1, 2018

Great! Thanks for reporting it. This is now published in v1.0.4.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.