-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tweak when we include the AR transaction callback rescuing #709
Conversation
if Rails::VESION::MAJOR == 4 | ||
if ActiveRecord::Base.errors_in_transactional_callbacks == :raise | ||
require "bugsnag/integrations/rails/active_record_rescue" | ||
include Bugsnag::Rails::ActiveRecordRescue | ||
end | ||
elsif Rails::VESION::MAJOR < 4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if Rails::VESION::MAJOR == 4 | |
if ActiveRecord::Base.errors_in_transactional_callbacks == :raise | |
require "bugsnag/integrations/rails/active_record_rescue" | |
include Bugsnag::Rails::ActiveRecordRescue | |
end | |
elsif Rails::VESION::MAJOR < 4 | |
if Rails::VERSION::MAJOR == 4 | |
if ActiveRecord::Base.errors_in_transactional_callbacks == :raise | |
require "bugsnag/integrations/rails/active_record_rescue" | |
include Bugsnag::Rails::ActiveRecordRescue | |
end | |
elsif Rails::VERSION::MAJOR < 4 |
Thanks for the PR, @apalmblad! I'll merge this in #717, where I've added tests to our Rails test apps to get better coverage of this behaviour |
Thanks for putting this in. |
Released in https://github.com/bugsnag/bugsnag-ruby/releases/tag/v6.24.2 🎉 , thanks for the contribution! |
Goal
Bugsnag notifies when we see an exception in a transaction (or rollback) callback. This is unnecessary as Rails now raises exceptions out of transaction callbacks. This Bugsnag behaviour means that certain errors are always sent to bugsnag instead of potentially handled elsewhere.
Bugsnag behaviour can be seen here: https://github.com/apalmblad/bugsnag-ruby/blob/master/lib/bugsnag/integrations/rails/active_record_rescue.rb#L14
Rails has stopped swallowing exceptions in these callbacks, making in configurable in Rails 4, and then the default behaviour in Rails 5.
Rails allowing exceptions to be raised
Rails 5 removing configuration for not raising callback exceptions
Design
To minimize changes needed, I consider the rails version and the various configuration values and conditionally include the file.
Changeset
The rails integration behaviour was changed, and we stop including it.
Testing
I've added a spec to check whether or not its included.