Use thread_queue delivery in Sidekiq #626
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
This PR switches the default delivery method used in Sidekiq to
thread_queue
, fromsynchronous
After quite a bit of testing this seems to be safe; it looks like Sidekiq was using
synchronous
only because Resque needs to usesynchronous
delivery (so just in case, rather than because we proved it was necessary)Changeset
Added
Removed
Changed
Tests
I did a bunch of manual testing to make sure this is safe and we have tests on various Sidekiq versions which would fail if we weren't delivering events. I've also made sure we test the default delivery method and, for completeness, that it can be changed
Linked issues
Related to #593
Review
For the submitter, initial self-review:
For the pull request reviewer(s), this changeset has been reviewed for: