-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add runtime version reporting to event and session payloads #560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomlongridge
force-pushed
the
tom/add_runtime_versions
branch
from
August 15, 2019 12:55
af3bdcd
to
bfbd64d
Compare
Should this target the |
tobyhs
reviewed
Aug 15, 2019
tobyhs
reviewed
Aug 16, 2019
tomlongridge
force-pushed
the
tom/add_runtime_versions
branch
from
August 22, 2019 17:42
61933d1
to
9a4f1d1
Compare
tobyhs
reviewed
Aug 22, 2019
tomlongridge
force-pushed
the
tom/add_runtime_versions
branch
from
August 23, 2019 08:37
c7d8306
to
ba5f03a
Compare
Adds Ruby/JRuby and framework versions to both event and session payload.
Also restore missing requires and remove json from configuration spec
tomlongridge
force-pushed
the
tom/add_runtime_versions
branch
from
August 23, 2019 08:45
ba5f03a
to
1d2aecd
Compare
tobyhs
approved these changes
Aug 23, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a few minor test code related comments, otherwise lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Augments reporting with the version of Ruby and integrated frameworks in use when an event occurred to aid diagnostics of version-specific bugs.
Design
Added data to device.runtimeVersions.ruby as per other notifiers.
Changeset
Changed
configuration.rb
- adds Ruby/JRuby version to new property hashruntime_version
report.rb
- adds the collected versions into the payloadsession_tracker.rb
- adds the collected versions into the payloadTests
Review
For the submitter, initial self-review:
For the pull request reviewer(s), this changeset has been reviewed for: