Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breadcrumbs: Add notify breadcrumb #513

Merged
merged 23 commits into from
Dec 17, 2018

Conversation

Cawllec
Copy link
Contributor

@Cawllec Cawllec commented Dec 12, 2018

Goal

Adds the "notify breadcrumb", logged when a notification is delivered, and tests.

Waiting for #512 before merging.

@Cawllec Cawllec requested review from tobyhs, kellymason and a team December 12, 2018 11:27
@Cawllec Cawllec changed the title Breadcrumbs/notify breadcrumb Breadcrumbs: Add notify breadcrumb Dec 12, 2018
Copy link
Contributor

@tobyhs tobyhs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm when #512 is approved and merged

@Cawllec Cawllec merged commit f3f2e15 into breadcrumbs/base Dec 17, 2018
@Cawllec Cawllec deleted the breadcrumbs/notify-breadcrumb branch December 17, 2018 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants