Breadcrumbs/leave breadcrumb #511
Conversation
|
Rubocop has an issue with the length of the |
.rubocop_todo.yml
Outdated
| @@ -302,7 +302,7 @@ Metrics/MethodLength: | |||
| # Offense count: 1 | |||
| # Configuration parameters: CountComments. | |||
| Metrics/ModuleLength: | |||
| Max: 125 | |||
| Max: 140 | |||
There was a problem hiding this comment.
It might be preferable to add lib/bugsnag.rb to Exclude instead of repeatedly bumping this limit.
lib/bugsnag.rb
Outdated
| unless breadcrumb.ignore? | ||
| # Run callbacks | ||
| configuration.before_breadcrumb_callbacks.each do |c| | ||
| (c.arity > 0 ? c.call(breadcrumb) : c.call) |
There was a problem hiding this comment.
Outermost parentheses are unnecessary here
| # Run callbacks | ||
| configuration.before_breadcrumb_callbacks.each do |c| | ||
| (c.arity > 0 ? c.call(breadcrumb) : c.call) | ||
| break if breadcrumb.ignore? |
There was a problem hiding this comment.
I think you can return here instead of breaking because it shouldn't proceed further if it is ignored.
spec/bugsnag_spec.rb
Outdated
| @@ -133,4 +133,153 @@ module Kernel | |||
| Kernel.send(:remove_const, :REQUIRED) | |||
| end | |||
| end | |||
|
|
|||
| describe "#leave_breadcrumb" do | |||
There was a problem hiding this comment.
.leave_breadcrumb (. instead of # as it is a module/class method on Bugsnag instead of an instance method)
spec/bugsnag_spec.rb
Outdated
| end | ||
|
|
||
| it "runs callbacks before leaving" do | ||
| Bugsnag.configuration.before_breadcrumb_callbacks << Proc.new { |breadcrumb| |
There was a problem hiding this comment.
I normally see do + end for multi-line blocks instead of curly braces ("Avoid using {...} for multi-line blocks" at https://github.com/rubocop-hq/ruby-style-guide#single-line-blocks )
lib/bugsnag.rb
Outdated
| break if breadcrumb.ignore? | ||
| end | ||
|
|
||
| # Validate again incase of callback alteration |
There was a problem hiding this comment.
"in case" (with a space in between)
Goal
Adds the
leave_breadcrumbmethod and associated tests for the Breadcrumbs implementation.