Updates to use sidekiq v3 error handling #434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I would like to see integration tests for this, rather than just unit. Can we add some maze tests? |
|
Will this address #417 too or is that being done in another PR? |
|
That will be in a separate PR, as decisions about that change still have to be made. |
|
I have reworked the approach here to give us the sidekiq queue information in all versions. I ran the maze tests and they all passed. |
kattrali
approved these changes
Jul 11, 2018
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensures that an error handler is correctly assigned in newer versions of sidekiq.
While it has very basic sidekiq integration tests already, this is a prime candidate for the new integrations test runner, which I will be working with this week.
Manually tested in: