-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added configuration option to disable autoconfiguration #419
Conversation
What manual testing has been done? |
I've tested it in rails to ensure the environment variable stops it from loading the railtie, which works correctly. I guess the main issue would be that it still loads in Edit: Meant |
We should test it for all the integrations to ensure that manually loading the sidekiq integration (as an example) works and we dont need to make any changes to support the later loading. |
Now tested and confirmed to work with:
Does not work with:
|
Rack or rake? Checking because rake was mentioned in #419 (comment) |
Rack. We loaded the Rack integration outside of the |
What broke when moving the import to the |
Nothing I suppose. I haven't added it to the loop yet (as it was separate anyway), but it shouldn't change the expected behaviour if I do. I'll do that and test it. |
Everything works as expected with rack, and there's no magic conf happening. |
This adds two functions,
load_integrations
&load_integration(integration)
that allow Bugsnag integrations to be loaded during runtime.By default,
load_integrations
will be run when thebugsnag
module is required. This behaviour can be disabled using the environment variableBUGSNAG_DISABLE_AUTOCONFIGURE
.Tentatively fixes #391, #403