Use lazy load hooks to hook on ActionController::Base: #393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Someone reverted my change #338 😢 |
lib/bugsnag/integrations/railtie.rb
Outdated
| if defined?(ActionController::API) | ||
| require "bugsnag/integrations/rails/controller_methods" | ||
| ActionController::API.send(:include, Bugsnag::Rails::ControllerMethods) | ||
| if defined?(ActionController::Base) || defined?(ActionController::API) |
There was a problem hiding this comment.
You don't need to check. Just define the hooks.
- Calling directly ActionController::Base affects the initialization process (one of them being one that controls ActionController configuration) - As a result setting configuration inside an initializer (such as the asset_host), doesn't have any effect
Edouard-chin
force-pushed
the
use-lazy-load-hooks
branch
from
a7f5bcf to
0448d02
Compare
|
Thanks for this, @Edouard-chin @rafaelfranca. We're going to take a look and figure out where a merge went awry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👋 Hello guys thanks for creating and maintaining this gem
Use lazy load hooks to hook on ActionController::Base: