Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include name of job class in context for Sidekiq and Resque errors. #293

Merged
merged 1 commit into from
Jun 17, 2016
Merged

Include name of job class in context for Sidekiq and Resque errors. #293

merged 1 commit into from
Jun 17, 2016

Conversation

johanlunds
Copy link
Contributor

@johanlunds johanlunds commented Apr 28, 2016

Fixes #258

I thought making context consistent was a good idea. I have not tested the change for Resque. I copied my code from the existing failure handler for Airbrake, so I think it should work. (I did not understand the code for delayed_job - it doesn't seem like it's setting context).

Examples:

  • NSQPoster on default
  • SendEmailToCustomer on emails

Screenshot

runtimeerror_in_rutilus__fishbrain__-_bugsnag

What do you think?

Examples:

* NSQPoster on default
* SendEmailToCustomer on emails
@kattrali
Copy link
Contributor

Thank you for the contribution, @johanlunds. This looks good.

@kattrali
Copy link
Contributor

Looking it over for Resque now.

@johanlunds
Copy link
Contributor Author

Could potentially change it to be NSQPoster@default instead of NSQPoster on default. That sort of matches movies#create that is the context for (Rails) request errors, and reads pretty well "NSQPoster at (@) default (queue)"

@kattrali
Copy link
Contributor

@johanlunds That makes sense. Would you mind making this change?

@johanlunds
Copy link
Contributor Author

Sure. Will do

On 12 maj 2016 19:01 +0200, Delisa [email protected], wrote:

@johanlunds(https://github.com/johanlunds)That makes sense. Would you mind making this change?


You are receiving this because you were mentioned.
Reply to this email directly orview it on GitHub(#293 (comment))

@codeanpeace
Copy link

Any updates on this?

@kattrali kattrali merged commit dfa12aa into bugsnag:master Jun 17, 2016
@kattrali
Copy link
Contributor

Thanks for the bump, @codeanpeace, and the PR, @johanlunds. I made the formatting change and released the new context display in v4.2.0

@johanlunds
Copy link
Contributor Author

Thank you! Sorry for the delay.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants