Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App Type is ignored when running rake tasks on a rails app. #351

Closed
zee-roostify opened this issue Mar 17, 2017 · 2 comments
Closed

App Type is ignored when running rake tasks on a rails app. #351

zee-roostify opened this issue Mar 17, 2017 · 2 comments

Comments

@zee-roostify
Copy link

zee-roostify commented Mar 17, 2017

Consider the following scenario:

Given a brand spanking new Rails app with bugsnag configured with `app_type="service-a"`
When I run `bin/rake bugsnag:test_exception`
Then I receive an exception with an app_type of `rake`
Instead I would like to receive an exception with the app_type of `service-a`

When looking at the rack middleware, I noticed that it used an ||= to set the app_type; which seems reasonable. However on rake, it always sets the app_type to rake

Because we have a service oriented architecture, we were planning to use the app_type to distinguish between the many different services in our deployments, (mailer-api, mailer-worker, mailer-rake) so that all exceptions stream in to the same project and can be filtered/explored/acted upon in this manner.

@zee-roostify
Copy link
Author

Whoops. Hit enter and it submitted before I filled out. One moment!

@kattrali
Copy link
Contributor

Thanks for the detailed report, @zee-roostify. This makes a lot of sense! Scheduling this in as an enhancement.

kattrali added a commit that referenced this issue Oct 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants