This repository has been archived by the owner on Sep 14, 2020. It is now read-only.
fix(podfile): fix missing comma in headers list #456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomlongridge
force-pushed
the
tom/fix-podspec-headers-list
branch
from
65bdbe9 to
2b1a42f
Compare
fractalwrench
approved these changes
May 7, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Adds the missing comma in the public_header_files in the podspec
Testing
Manually tested following online enhanced native instructions to include required headers (
<BugsnagReactNative/BugsnagReactNative.h>andBugsnagConfiguration.h).Linked issues
Related to #453