This repository has been archived by the owner on Dec 4, 2018. It is now read-only.
Pass original error to pre-send callbacks #103
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes additional context available on the error instance is needed when creating error reports, which can then be used to attach metadata or decide to cancel the report. This change adds the original error which generated the report as a parameter to
beforeNotifyCallbacks
.Here's an example of attaching custom error properties (from #101) which is then easily fixable:
The metadata of the report then includes the tab "Detailed Error Data" including the non-default fields. There is a similar example in the tests. Later I'd like to revisit this case to potentially do this behavior by default.
Fixes #101