Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(expo): Improve support for Expo Application Services #1686

Conversation

kennethlynne
Copy link
Contributor

@kennethlynne kennethlynne commented Feb 4, 2022

Goal

Don't crash clients using Expo Application Services. Related to #1683

Changeset

Using EAS and specifically EAS updates currently crashes bugsnag. This change should solve this.

Testing

We use this in our clients. Will expand tests if someone from bugsnag confirms they will accept the change

@luke-belton
Copy link

Hi @kennethlynne - thanks for opening this. We've got an item on our roadmap to look into adding support for EAS updates. We'll review this PR as priorities allow and keep you updated 👍

@luke-belton luke-belton added backlog We hope to fix this feature/bug in the future feature request Request for a new feature labels Feb 8, 2022
@kennethlynne
Copy link
Contributor Author

Great. I'll take the time to add tests and clean up this if you confirm at some point

@y471n
Copy link

y471n commented Mar 3, 2022

Any update on this? Is this getting merged anytime soon?

@avikantz
Copy link

avikantz commented Mar 4, 2022

Also facing this issue, can we get this merged soon?

@imjoehaines
Copy link
Contributor

Thanks for the PR, @kennethlynne!

I've made a few additional changes in #1695, so this'll be merged there

@imjoehaines imjoehaines closed this Mar 7, 2022
@imjoehaines imjoehaines mentioned this pull request Mar 8, 2022
@luke-belton
Copy link

We've released preliminary support for Expo EAS Update in v7.16.2 of bugsnag-js 🎉

Please let us know if you have any feedback about how we can improve our support for EAS Update in the future!

@luke-belton luke-belton added released This feature/bug fix has been released and removed backlog We hope to fix this feature/bug in the future labels Mar 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Request for a new feature released This feature/bug fix has been released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants