Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RN example fixes #1680

Merged
merged 3 commits into from
Feb 2, 2022
Merged

RN example fixes #1680

merged 3 commits into from
Feb 2, 2022

Conversation

gareththackeray
Copy link
Contributor

Goal

The RN example apps were not working for me

Changeset

  • iOS - removed Flipper
  • JS - updated reference to @bugsnag/react-native to latest

imjoehaines
imjoehaines reviewed Jan 31, 2022
View reviewed changes
Copy link
Contributor

@imjoehaines imjoehaines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should be pinning examples to exact versions, but otherwise LGTM

examples/reactnative/rn060example/package.json Outdated Show resolved Hide resolved
examples/reactnative/rn063example/package.json Outdated Show resolved Hide resolved
@github-actions
Copy link

@bugsnag/browser bundle size diff

Minified Minfied + Gzipped
Before 42.85 kB 13.07 kB
After 42.85 kB 13.07 kB
± No change No change

code coverage diff

Coverage values did not change👌.

Total:

Lines Branches Functions Statements
0%(+0%) 0%(+0%) 0%(+0%) 0%(+0%)

Generated by 🚫 dangerJS against eda0af3

@imjoehaines imjoehaines merged commit 0f53a6b into next Feb 2, 2022
@imjoehaines imjoehaines deleted the rn-example-fixes branch February 2, 2022 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imjoehaines imjoehaines imjoehaines approved these changes

@nickdowell nickdowell nickdowell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gareththackeray @nickdowell @imjoehaines