Add tests for React Navigation 6 #1677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twometresteve
force-pushed
the
tms/enabled-breadcrumbs-fix
branch
from
9310d72 to
a4b049c
Compare
imjoehaines
approved these changes
Jan 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Updates the React Navigation tests for RN 0.63 run with React Navigation v6.
Design
A fix was needed to the test fixture code responsible for setting the enabledBreadcrumbTypes in Bugsnag configuration on iOS to achieve this.
Changeset
enabledBreadcrumbTypesin iOS testsenabledBreadcrumbTypesin actionTesting
Covered by CI and I have also run the navigation tests on iOS locally 30 times without a failure.