Force DEVELOPER_DIR for pipeline steps #1672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -282,7 +282,7 @@ steps: | |||
| env: | |||
| DEBUG: true | |||
| LANG: "en_US.UTF-8" | |||
| DEVELOPER_DIR: "/Applications/Xcode11.7.app" | |||
| DEVELOPER_DIR: "/Applications/Xcode11.app" | |||
There was a problem hiding this comment.
It's probably not a problem if the build works, but I notice that RN 0.63 builds with Xcode 12 in the main RN pipeline.
There was a problem hiding this comment.
Hmm the only reason that this would have been added is because that it was building on the old ms-mac-10-15 queue. I'll double check.
There was a problem hiding this comment.
This step used to be on the opensource-mac-rn queue which was the old 10-15 macs
There was a problem hiding this comment.
Yeah, there's a fair bit of history in these pipelines. If they both build I think it's fine.
twometresteve
approved these changes
Jan 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Set the
DEVELOPER_DIRfor each step as required so that we set which version of Xcode we want to use.Changeset
Add the environment variable
DEVELOPER_DIRfor each step that requires it.Testing
Automated Tests have been run.