Revert "Recursive metadata is now handled in react native"

bugsnag · Jan 19, 2022 · 99a0cb4 · 99a0cb4
1 parent 0baeac0
commit 99a0cb4
Show file tree

Hide file tree

Showing 7 changed files with 4 additions and 203 deletions.
diff --git a/packages/delivery-react-native/delivery.js b/packages/delivery-react-native/delivery.js
@@ -1,5 +1,3 @@
-const makeSafe = require('./make-safe')
-
 module.exports = (client, NativeClient) => ({
   sendEvent: (payload, cb = () => {}) => {
     const event = payload.events[0]
@@ -19,10 +17,10 @@ module.exports = (client, NativeClient) => ({
       app: event.app,
       device: event.device,
       threads: event.threads,
-      breadcrumbs: makeSafe(event.breadcrumbs),
+      breadcrumbs: event.breadcrumbs,
       context: event.context,
       user: event._user,
-      metadata: makeSafe(event._metadata),
+      metadata: event._metadata,
       groupingHash: event.groupingHash,
       apiKey: event.apiKey,
       nativeStack: nativeStack

diff --git a/packages/delivery-react-native/make-safe.js b/packages/delivery-react-native/make-safe.js
diff --git a/packages/delivery-react-native/test/make-safe.test.ts b/packages/delivery-react-native/test/make-safe.test.ts
diff --git a/...act-native/features/fixtures/app/scenario_js/app/scenarios/BreadcrumbsJsManualScenario.js b/...act-native/features/fixtures/app/scenario_js/app/scenarios/BreadcrumbsJsManualScenario.js
@@ -6,10 +6,6 @@ export class BreadcrumbsJsManualScenario extends Scenario {
     const metaData = {
       from: 'javascript'
     }
-
-    // ensure that circular references are safely handled
-    metaData.circle = metaData
-
     Bugsnag.leaveBreadcrumb('oh crumbs', metaData, 'state')
     Bugsnag.notify(new Error('BreadcrumbsJsManualScenario'))
   }

diff --git a/test/react-native/features/fixtures/app/scenario_js/app/scenarios/MetadataJsScenario.js b/test/react-native/features/fixtures/app/scenario_js/app/scenarios/MetadataJsScenario.js
@@ -13,13 +13,8 @@ export class MetadataJsScenario extends Scenario {
   }
 
   run () {
-    const recursiveMetadata = {}
-    recursiveMetadata.data = 'some valid data'
-    recursiveMetadata.circle = recursiveMetadata
-
     Bugsnag.addMetadata('jsdata', 'some_more_data', 'set via client')
     Bugsnag.addMetadata('jsdata', 'redacted_data', 'not present')
-    Bugsnag.addMetadata('jsdata', 'recursive', recursiveMetadata)
     Bugsnag.notify(new Error('MetadataJsScenario'), (event) => {
       event.addMetadata('jsdata', 'even_more_data', 'set via event')
       event.addMetadata('jsarraydata', 'items', ['a', 'b', 'c'])

diff --git a/test/react-native/features/fixtures/expected_breadcrumbs/JsManualScenario.json b/test/react-native/features/fixtures/expected_breadcrumbs/JsManualScenario.json
@@ -3,7 +3,6 @@
     "name": "oh crumbs",
     "timestamp": "^\\d{4}\\-\\d{2}\\-\\d{2}T\\d{2}:\\d{2}:[\\d\\.]+Z?$",
     "metaData": {
-        "from": "javascript",
-        "circle": "[Circular]"
+        "from": "javascript"
     }
-}
+}
diff --git a/test/react-native/features/metadata.feature b/test/react-native/features/metadata.feature
@@ -9,8 +9,6 @@ Scenario: Setting metadata (JS)
   And the event "metaData.jsdata.some_more_data" equals "set via client"
   And the event "metaData.jsdata.even_more_data" equals "set via event"
   And the event "metaData.jsdata.redacted_data" equals "[REDACTED]"
-  And the event "metaData.jsdata.recursive.data" equals "some valid data"
-  And the event "metaData.jsdata.recursive.circle" equals "[Circular]"
   And the error payload field "events.0.metaData.jsarraydata.items" is an array with 3 elements
 
 Scenario: Setting metadata (native handled)