Add ErrorWithCallers interface #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows the creation of error objects other than bugsnag.Error that have stack-traces. The use case for us is making errors that are Retryable and also have the right stack trace: https://github.com/codeship/go-retro
|
Very cool! Yeah, a general rethinking of the library is due soon, and it would be good to use an interface type in the (major revision) future. In the meantime, this looks like a good addition. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the creation of error objects other than bugsnag.Error that have stack-traces.
The use case for us is making errors that are Retryable and also have the right stack trace: https://github.com/codeship/go-retro
Now I have more experience with go, I'd probably have written this library to use an interface type rather than a struct type from the start; but this is a backward compatible addition.