feat(errors): extract pkg/errors stacktraces #144
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Support reporting stack traces captured using the
pkg/errors
package instead of generating a new stack whenNotify()
is called.Closes #128 - updates the premise to use the latest pre-release branch and avoids adding go module files, which will be handled in a dedicated changeset.
Design
Create a new interface for objects implementing
StackTrace()
, returning anerrors.StackTrace
instance (which is an array ofuintptr
representing program counters). Given the array of program counters, the error can be processed normally.Changeset
errorWithStack
to represent the new error type (theerrors
package does not export this interface but it is listed as stable)Testing
error
using theerrors.Wrap()
function, which generates a stack trace. This test verifies that the generated stack is used rather than creating a new one when[bugsnag.]errors.New()
is called.