Runtime versions

[kinbiko]

Goal

Introduce runtime version data to the report and session payloads.

Changeset

Added

device.RuntimeVersions
device.GetRuntimeVersions()
device.AddVersion

Changed

• Session and report payloads.
• Revel example README (fix typo)
• Introduced OS Name in report payload as well (already existed in session payload)

Tests

Added some unit tests, and verified that the payloads show up as expected, including the new runtime version data.

Not great

It's unfortunate that we're using a global variable for the runtime versions, but this cached value simplifies things a lot, and is relatively harmless in this package. If/when we decide to upgrade to a v2 we should get rid of all global state anyway.

Linked issues

#121 is the first commit on this branch in order to get a passing build.

Review

For the submitter, initial self-review:

• Commented on code changes inline explain the reasoning behind the approach
• Reviewed the test cases added for completeness and possible points for discussion
• A changelog entry was added for the goal of this pull request
• Check the scope of the changeset - is everything in the diff required for the pull request?
• This pull request is ready for:
  • Initial review of the intended approach, not yet feature complete
  • Structural review of the classes, functions, and properties modified
  • Final review

For the pull request reviewer(s), this changeset has been reviewed for:

• Consistency across platforms for structures or concepts added or modified
• Consistency between the changeset and the goal stated above
• Internal consistency with the rest of the library - is there any overlap between existing interfaces and any which have been added?
• Usage friction - is the proposed change in usage cumbersome or complicated?
• Performance and complexity - are there any cases of unexpected O(n^3) when iterating, recursing, flat mapping, etc?
• Concurrency concerns - if components are accessed asynchronously, what issues will arise
• Thoroughness of added tests and any missing edge cases
• Idiomatic use of the language

[bengourley]

Looks good to me. Eyeballed and tested manually, working well.

I understand your point about hostname being global, but it's seemingly not related to this PR? Or am I missing something?

[kinbiko]

Good eye @bengourley -- that was a slip. I meant to say runtime versions instead of hostname, but the same applies (already) for hostname.