Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport persistenceDirectory config option #6

Merged
merged 3 commits into from
Nov 29, 2021

Conversation

fractalwrench
Copy link
Contributor

@fractalwrench fractalwrench commented Nov 26, 2021

Goal

Updates the SDK to support the persistenceDirectory config option on Android, as added in here: bugsnag/bugsnag-android#1532

Testing

Manually verified in the Android example app that the error/session files can be stored in the filesDir instead of the default cacheDir.

@fractalwrench fractalwrench force-pushed the PLAT-7654/backport-persistence-dir branch from afde1d7 to c9e925d Compare November 26, 2021 14:05
@fractalwrench fractalwrench marked this pull request as ready for review November 26, 2021 14:44
@fractalwrench fractalwrench requested a review from lemnik November 29, 2021 10:40
Copy link
Contributor

@lemnik lemnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fractalwrench fractalwrench merged commit 0b64996 into next Nov 29, 2021
@fractalwrench fractalwrench deleted the PLAT-7654/backport-persistence-dir branch November 29, 2021 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants