[PLAT-5965] Fix analyzer warning in BugsnagClient.m #994
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickdowell
force-pushed
the
nickdowell/fix-analyzer-warning
branch
from
32c19fd to
48a2b6b
Compare
nickdowell
force-pushed
the
nickdowell/fix-analyzer-warning
branch
from
48a2b6b to
f4c4fc8
Compare
kstenerud
approved these changes
Feb 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Addresses an analyzer warning reported in #989
Changeset
-orientationChanged:was being called with anilnotification, causing anilmessage to be passed toaddAutoBreadcrumbOfType:...The purpose of that call to
-orientationChanged:was to ensure the state metadata would contain the initial orientation, this logic has now been moved to-initWithConfiguration:Testing
Was able to reproduce when running the analyzer with a simulator target as show in #989, and confirm there is no longer a warning.