[PLAT-5702] Capture NSError userInfo #974
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickdowell
force-pushed
the
nickdowell/nserror-userinfo
branch
from
c52a95b to
a5d2db7
Compare
nickdowell
force-pushed
the
nickdowell/nserror-userinfo
branch
from
a5d2db7 to
945f144
Compare
nickdowell
changed the title
kattrali
approved these changes
Jan 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Include the NSError's userInfo in error reports.
Design
The
nserrormetaData now includes auserInfovalue which contains a sanitised version of the NSError's userInfo property.Since it is a dictionary, it is fully searchable in the dashboard.
Changeset
-[BugsnagClient appendNSErrorInfo:block:event:]now includesuserInfoin thenserrormetadata.Added
BSGJSONDictionary()function to create a JSON sanitised JSON version of userInfo.Testing
Manually tested using example app.
Added new unit test for
BSGJSONDictionary()Updated barebones test to verify presence of
nserror.userInfo