[PLAT-5451] Fix missing session information in OOM events #963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickdowell
changed the title
nickdowell
force-pushed
the
nickdowell/fix-oom-session-info
branch
from
d385af5 to
d712d20
Compare
kstenerud
approved these changes
Jan 8, 2021
kattrali
approved these changes
Jan 8, 2021
nickdowell
force-pushed
the
nickdowell/fix-oom-session-info
branch
from
ac3d2a2 to
93fb5f4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
OOM events used to contain session information, but this was inadvertently removed by a regression introduced in v6.2.0.
These changes reintroduce the session information in OOM events and add verification of this in the E2E tests.
Changeset
BugsnagSystemStatenow records the session information when a BSGSessionUpdateNotification is posted, just likeBSGOutOfMemoryWatchdogused to.-[BugsnagEvent initWithOOMData:]still contains the code to read the session information from the data stored byBugsnagSystemState.Testing
Tested manually using the example app, and by amending & running the E2E tests.