Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unhandledOverride #937

Merged
merged 1 commit into from
Dec 14, 2020
Merged

Fix unhandledOverride #937

merged 1 commit into from
Dec 14, 2020

Conversation

kstenerud
Copy link
Contributor

Goal

The last unhandled override PR incorrectly placed unhandledOverride at the top level, when it should have been inside of severityReason.

Changeset

Update JSON serializer and deserializer code to place it at the correct level, and update tests to match.

Testing

Re-ran unit tests and e2e tests.

@kstenerud kstenerud changed the base branch from master to next December 11, 2020 15:29
nickdowell
nickdowell approved these changes Dec 11, 2020
View reviewed changes
Copy link
Contributor

@nickdowell nickdowell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if the E2E tests pass

@kstenerud kstenerud merged commit 8f15701 into next Dec 14, 2020
@kstenerud kstenerud deleted the 0000-fix-unhandled-override branch December 14, 2020 08:44
@kstenerud kstenerud mentioned this pull request Dec 14, 2020
Merged
@bengourley bengourley mentioned this pull request Dec 14, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickdowell nickdowell nickdowell approved these changes

@tomlongridge tomlongridge Awaiting requested review from tomlongridge

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kstenerud @nickdowell