[PLAT-5449] Include metadata in OOM events #915
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kstenerud
requested changes
Nov 27, 2020
kstenerud
approved these changes
Dec 1, 2020
kattrali
approved these changes
Dec 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
OOM events were missing some important data that are present in other types of error:
The changes in this PR add this information to OOMs.
Design
See the design document on Confluence.
Changeset
Metadata is now written to files on disk and read from there when constructing a KSCrashReport.
-[BugsnagEvent initWithOOMData:]has been amended to use this newly available information.The device data being captured in
BugsnagSystemStatebecomes redundant as it exists in the "state" metadata, so has been removed.out_of_memory.featureno longer checks fordevice.orientationbecause that is not present in other types of error.Testing
Manually verified by triggering OOMs and examining payload.
Updated
out_of_memory.featureto verify that custom metadata and user information is present and in the expected location within the payload.