Fix crash in -[BugsnagSystemState sync] #893
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
The crash was reported against
-[BugsnagSystemState sync] + 203
(BugsnagSystemState.m:203) which is retaining thecurrentLaunchState
property.This crashed because
currentLaunchState
was declarednonatomic
but is being set and read from different threads.Changeset
currentLaunchState
propertyatomic
- this ensures the returned object will not be deallocated by a setting thread before the getter completes.nonatomic
properties asreadonly
where appropriate to avoid similar issues being introduced in the future.Testing
N/A