Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
When version data is not manually specified, it doesn't get stored to the config metadata JSON buffer, and thus doesn't get stored in any crash events. When loading the event, BugsnagApp tries to fetch the data from the event, then the config, then system data. Since the event data is not present, it ends up fetching current data instead of past data, and gives mismatched values for
app version
andversion
if they happen to change between the last crash and the next launch.Design
Force version and app version to be persisted to the config metadata so that it's always available from config no matter how it was initialised.
ReleaseStage
andAppType
have also been modified to store their defaults this way.Testing
Tested crashing the example app and changing version info before relaunch under the following conditions: