Send severity and breadcrumbs with uncaught exceptions #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| [self resetDefaultSeverity]; | ||
| } | ||
|
|
||
| - (void) resetDefaultSeverity { |
There was a problem hiding this comment.
Could we instead say that if severity is nil then we should set it to error in the sink?
There was a problem hiding this comment.
I wondered about that. Is it weird to modify the payloads during the filter step though?
There was a problem hiding this comment.
I dont think so. I think we'd just be saying that if one wasnt written it was in fact an error. I dont mind which direction we head in but wanted to point it out as an option.
There was a problem hiding this comment.
Yeah, I could see that. and then I can move all of this logic as one unit. Patched.
|
This LGTM! |
Use error as the default severity, which is overridden by manual error notifications
kattrali
force-pushed
the
kattrali/send-severity-breadcrumbs-with-uncaught
branch
from
f05c0af to
a94ddb4
Compare
|
👍 👍 🌳 |
kattrali
added a commit
that referenced
this pull request
Feb 3, 2016
…s-with-uncaught Send severity and breadcrumbs with uncaught exceptions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
errorin case of an uncaught exception. It is still overridden in the case of a handled exception.serializedDictionary:toJSON:into a function,BSSerializeJSONDictionaryFixes #58