Catch JSON exceptions rather than crashing #856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kstenerud
force-pushed
the
5297-catch-json-errors
branch
from
d2c304a to
24d6b09
Compare
kstenerud
changed the title
… rather than crashing.
kstenerud
force-pushed
the
5297-catch-json-errors
branch
from
24d6b09 to
7fd3161
Compare
|
Is there a way to have automated test coverage of this? |
|
I'm not sure... So far the only exceptions I've managed are alloc exceptions during OOM situations. Other kinds of exceptions would require a bug in the codec. |
nickdowell
approved these changes
Oct 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
We've previously made changes to wrap
NSJSONSerializationto catch unexpected exceptions while encoding/decoding, but there is still an alternative path that hasn't been handled.Design
Replicate the technique from
BSGJSONSerializationinBSG_KSJSONCodec(wrap top-level APIs in try/catch blocks)Changeset
BSG_KSJSONCodechas been modified such that the top-level APIs are guarded with try/catch blocks that log any errors.Testing
Created a test app that exhausts memory in a region that uses the JSON serialization and observed the error messages prior to it crashing elsewhere from OOM.