Use os_proc_available_memory if available #851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kstenerud
force-pushed
the
5236-os_proc_available_memory
branch
from
2cacc5a to
3aac0b4
Compare
kstenerud
force-pushed
the
5236-os_proc_available_memory
branch
3 times, most recently
from
e0df55a to
1715447
Compare
nickdowell
suggested changes
Oct 20, 2020
kstenerud
force-pushed
the
5236-os_proc_available_memory
branch
5 times, most recently
from
f02e5bd to
e9f8b6f
Compare
kstenerud
force-pushed
the
5236-os_proc_available_memory
branch
from
e9f8b6f to
a08363d
Compare
nickdowell
approved these changes
Oct 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Apple provides a more accurate measure of usable memory in iOS 13 compared to what we use currently. We should use it when it's available.
Design
Modified
bsg_ksmachusableMemory()to callos_proc_available_memory()when it's available.Testing
Ran all unit tests on all platforms, and did manual tests to verify that the free memory values make sense.